Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix disassemble of xor #2023

Merged
merged 1 commit into from
May 18, 2023
Merged

Fix disassemble of xor #2023

merged 1 commit into from
May 18, 2023

Conversation

imbillow
Copy link
Contributor

@imbillow imbillow commented May 17, 2023 •
edited
Loading

In fact, it seems that I didn't change much, I just updated the auto-generated code and did some adaptations.

after

cstool -d tc162 8fff8381
 0  8f ff 83 81  xor	%d8, %d15, 0x3f
	ID: 390 (xor.t)
	op_count: 3
		operands[0].type: REG = d8
		operands[1].type: REG = d15
		operands[2].type: IMM = 0x3f

before

cstool -d tc162 8fff8381
 0  8f ff 83 81  xor	0x3f, , 
	ID: 390 (xor)
	op_count: 1
		operands[0].type: IMM = 0x3f

@imbillow imbillow mentioned this pull request May 17, 2023
Merged
5 tasks
XVilka
XVilka approved these changes May 18, 2023
View reviewed changes
Copy link
Contributor

@XVilka XVilka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Rot127 @kabeor @aquynh please take a look

@kabeor
Copy link
Member

kabeor commented May 18, 2023

Great, thx!

@kabeor kabeor merged commit 605e116 into capstone-engine:next May 18, 2023
@imbillow imbillow deleted the tricore_fix branch May 20, 2023 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@XVilka XVilka XVilka approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@imbillow @kabeor @XVilka