Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use calloc for cs_insn instead of malloc #1972

Merged
merged 1 commit into from
Jun 26, 2023
Merged

use calloc for cs_insn instead of malloc #1972

merged 1 commit into from
Jun 26, 2023

Conversation

ConnorRigby
Copy link
Contributor

Fixes #1971

@ConnorRigby
use calloc for cs_insn instead of malloc
f68d167 
Signed-off-by: Connor Rigby <connorr@hey.com>
@XVilka
Copy link
Contributor

XVilka commented Jun 23, 2023

@kabeor @aquynh, maybe it's time to reconsider? @Rot127 do you have any opinion about this suggestion?

@Rot127
Copy link
Collaborator

Rot127 commented Jun 23, 2023

I am in favor of zeroing out the memory before use. We had at least one or two bugs due to not doing it.
But I can not judge about performance. This is out of my area of expertise.

@aquynh aquynh merged commit 3341c1a into capstone-engine:next Jun 26, 2023
@aquynh
Copy link
Collaborator

aquynh commented Jun 26, 2023

merged, thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

cs_insn mnemonic isn't 0'd before use.
4 participants
@ConnorRigby @XVilka @Rot127 @aquynh