Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Renesas SuperH instructions support #1927

Merged
merged 8 commits into from
Jan 27, 2023
Merged

Conversation

ysat0
Copy link
Contributor

@ysat0 ysat0 commented Oct 13, 2022

This changes added Renesas SuperH CPUs instruction support.

Signed-off-by: Yoshinori Sato <ysato@users.sourceforge.jp>
Signed-off-by: Yoshinori Sato <ysato@users.sourceforge.jp>
Signed-off-by: Yoshinori Sato <ysato@users.sourceforge.jp>
@aquynh
Copy link
Collaborator

aquynh commented Oct 13, 2022

nice, please add a sample test under tests/ directory for your arch.

is this coming from LLVM? if so, please put the version information somewhere under arch/SH.

@aquynh
Copy link
Collaborator

aquynh commented Oct 13, 2022

sh.h is missing.

please fix the CI.

Signed-off-by: Yoshinori Sato <ysato@users.sourceforge.jp>
Signed-off-by: Yoshinori Sato <ysato@users.sourceforge.jp>
@ysat0
Copy link
Contributor Author

ysat0 commented Nov 4, 2022

Sorry. I overlooked your comment.
This change is not related to LLVM.
Added missing files. It should now build.

@aquynh
Copy link
Collaborator

aquynh commented Nov 4, 2022 via email

@ysat0
Copy link
Contributor Author

ysat0 commented Nov 4, 2022

This is it.
commit fb25d7f
Author: Yoshinori Sato ysato@users.sourceforge.jp
Date: Wed Oct 12 20:02:14 2022 +0900

sh: testcase

Signed-off-by: Yoshinori Sato <ysato@users.sourceforge.jp>

Signed-off-by: Yoshinori Sato <ysato@users.sourceforge.jp>
Signed-off-by: Yoshinori Sato <ysato@users.sourceforge.jp>
@DMaroo
Copy link

DMaroo commented Nov 28, 2022

Can this be merged? It'd be nice to have SuperH disassembly support in Capstone. Rizin has it's own makeshift disassembler, but it'd be nice for us to use this one, since we already use Capstone for disassembling other architectures.

@aquynh
Copy link
Collaborator

aquynh commented Nov 28, 2022

sorry for delay, i will have a quick review this week.

@DMaroo
Copy link

DMaroo commented Dec 8, 2022

Any updates on this? @aquynh

Copy link
Member

@kabeor kabeor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good for me. Any question? @aquynh Or I'll merge it this week.

@XVilka
Copy link
Contributor

XVilka commented Jan 27, 2023

@kabeor have you had a time to check this?

@kabeor
Copy link
Member

kabeor commented Jan 27, 2023

Happy Chinese New Year!Thanks for your contribution. Merged.

@kabeor kabeor merged commit 6eb1db9 into capstone-engine:next Jan 27, 2023
@ysat0 ysat0 deleted the superh branch January 28, 2023 09:23
@ysat0
Copy link
Contributor Author

ysat0 commented Jan 28, 2023

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants