-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Renesas SuperH instructions support #1927
Conversation
Signed-off-by: Yoshinori Sato <ysato@users.sourceforge.jp>
Signed-off-by: Yoshinori Sato <ysato@users.sourceforge.jp>
Signed-off-by: Yoshinori Sato <ysato@users.sourceforge.jp>
nice, please add a sample test under tests/ directory for your arch. is this coming from LLVM? if so, please put the version information somewhere under arch/SH. |
sh.h is missing. please fix the CI. |
Signed-off-by: Yoshinori Sato <ysato@users.sourceforge.jp>
Signed-off-by: Yoshinori Sato <ysato@users.sourceforge.jp>
Sorry. I overlooked your comment. |
Please add tests/test_sh.c
|
This is it.
|
Signed-off-by: Yoshinori Sato <ysato@users.sourceforge.jp>
Signed-off-by: Yoshinori Sato <ysato@users.sourceforge.jp>
Can this be merged? It'd be nice to have SuperH disassembly support in Capstone. Rizin has it's own makeshift disassembler, but it'd be nice for us to use this one, since we already use Capstone for disassembling other architectures. |
sorry for delay, i will have a quick review this week. |
Any updates on this? @aquynh |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good for me. Any question? @aquynh Or I'll merge it this week.
@kabeor have you had a time to check this? |
Happy Chinese New Year!Thanks for your contribution. Merged. |
Thanks. |
This changes added Renesas SuperH CPUs instruction support.