-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed SME index alias printing issue. #1925
Conversation
Hey, thanks for your contribution. Any examples for your changes? |
Hi, prior to this change some SME instructions were not printing in cstool correctly. This would happen when an instruction that has an operand such as So, before this change,
Which has too many operands, an additional memory operand, and hasn't stored the immidate value of the index ( After this change,
Which is correct |
The changes made in the second commit was to fix the failing PyPI tests in |
I fixed that already, maybe you can remove that commit and merge the latest next branch? |
I think the changes I made are still worth it as it keeps all for loops in the AArch64InstrPrinter file consistent. But if this isn't essential than I'll happily remove the commit |
Oh, that's good too. I will test your first commit asap. |
Hi, have you managed to take a look at the changes yes? |
Really cool! Thanks again for your great work. Merged. |
This fixes issue #1924 where some SME instructions were not being printed correctly when aliased as the SME index was being recognised as a memory operand by mistake.