Remove outdated ctypes requirement #1910
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
plz rebase to 'next' branch |
The library ctypes has shipped with the python standard library since Python 2.5, however this was still added via the `requires` keyword in setuptools.setup. This results in a spurious requirement being created in the .whl METADATA file, causing warnings when packaged via tools like pex: ``` $ python3 -m pex capstone -o capstone.pex /Users/ott/.venv/lib/python3.9/site-packages/pex/dist_metadata.py:397: PEXWarning: Ignoring 1 `Requires` field in /Users/ott/.pex/installed_wheels/2a4c7a0d4c87aceed3134ae20997a764af1811fee8e151cf5da90e0462822893/capstone-4.0.2-py3-none-macosx_12_arm64.whl metadata: 1.) Requires: ctypes You may have issues using the 'capstone' distribution as a result. More information on this workaround can be found here: pex-tool/pex#1201 (comment) ``` Since this requirement is outdated, it can just be removed.
jbott
force-pushed
the
remove-ctypes-install-requirement
branch
from
69f8be6
to
b62e69e
Compare
|
Cool, thx! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The library ctypes has shipped with the python standard library since
Python 2.5, however this was still added via the
requireskeyword insetuptools.setup. This results in a spurious requirement being created
in the .whl METADATA file, causing warnings when packaged via tools like
pex:
Since this requirement is outdated, it can just be removed.