Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AArch64: fix missing VAS specifiers in aliased instructions #1860

Merged
merged 4 commits into from
Mar 23, 2022

Conversation

adamjseitz
Copy link
Contributor

This PR fixes missing VAS specifiers in aliased instructions on AArch64, outlined in #1843.

@adamjseitz
Copy link
Contributor Author

I have similar concerns about the test I added as in my other PR, #1859:

I've added a test under suite/regress, modeled after the one added in #1840, but I could not find where these run in the GitHub Actions configuration, if at all, so I am concerned that these regression tests might not actually be running.

Let me know if there is a better place to be putting these sorts of tests, or if I should investigate adding these to the GitHub Actions configuration.

adamjseitz and others added 2 commits March 22, 2022 09:23
Add four tests to the cstest suite to validate issue capstone-engine#1843 does not
regress. Additionally, update the way VAS specifiers are printed so
that the correct operand is verified.
@kabeor kabeor merged commit c57915c into capstone-engine:next Mar 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants