Fixes the (pip) Python Module build on FreeBSD. #1750
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tomasz 'CeDeROM' CEDRO <tomek@cedro.info>
This was referenced May 11, 2021
|
merged, thanks! |
|
Thank you @aquynh :-) When next release is planned so we could have it working out of the box with |
|
@aquynh can you please create a new release? |
|
Yes we try to do that but will be a 5.0-rc1 first.
…On Mon, Jan 24, 2022, 07:22 Tomasz CEDRO ***@***.***> wrote:
@aquynh <https://github.com/aquynh> can you please create a new release?
pip still fails on the BSD because there has been no release since patch
was provided..
—
Reply to this email directly, view it on GitHub
<#1750 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABNQNYF2ITLAKEGQ5GNEBZ3UXSETXANCNFSM44T7B4QA>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
Thank you @aquynh 5.0 is fine too.. can I help anyhow? :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the manual and
pipPython Module build on FreeBSD.FreeBSD distinguishes make (BSD) vs gmake (GNU) so cmake + bsd make needs to be used.
Although FreeBSD provides capstone system packages, this module will build and install its own C extensions.
capstone-build-fixed.txt
capstone-build-fixed-tests.txt
Signed-off-by: Tomasz 'CeDeROM' CEDRO tomek@cedro.info