python: only use ascii character #1704
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Otherwise python setup.py install from bindings/python will fail with SyntaxError: Non-ASCII character '\xe2' in file setup.py on line 223, but no encoding declared; see http://python.org/dev/peps/pep-0263/ for details
|
CIFuzz because this commit needs to be cherry-picked in v4 branch as well |
|
merged, thanks! |
|
Should I make a PR for branch v4 as well ? |
aquynh
pushed a commit
that referenced
this pull request
Nov 17, 2020
Otherwise python setup.py install from bindings/python will fail with SyntaxError: Non-ASCII character '\xe2' in file setup.py on line 223, but no encoding declared; see http://python.org/dev/peps/pep-0263/ for details
|
i already cherry-picked, so you dont need to do that, thanks!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise python setup.py install from bindings/python
will fail with
SyntaxError: Non-ASCII character '\xe2' in file setup.py on line 223,
but no encoding declared; see http://python.org/dev/peps/pep-0263/ for details
Should fix oss-fuzz build
https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=27542