-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Correcting X86 Imm Size #1657
Correcting X86 Imm Size #1657
Conversation
Hi! Is any chance that this gets merged? |
@NicolasDerumigny Hello, can you do a comparative test case so that we can see the problem more intuitively? |
I am unsure what you mean. Do you want me to implement some checks in |
looks no need. will merge soon. Thanks for your contribution |
This commit broke several tests in r2 (radareorg/radare2#19402) I have compared the results with ghidra, binary ninja and IDA, and capstone is doing wrong after this patch. may be good to add some tests before merging things |
yeah, this broke some test for us too.
This is after the change, but it is supposed to be (it is
this is X86_AND64ri8 with encoding size 1 and operand size 8. so: |
I am sorry for this bug, I am using capstone as a dependency and needed this patch so that the immediate size was correctly reported; I am trying to find exactly the example where this was needed and will reply as soon as I have found it. |
Okey, I believe this MR is utter garbage. My issue was that |
revert this first, hope you can fix it |
We need to fix CI asap.
|
Correcting non-opened issue: x86 imm size is incorrectly reported (inversion of the first two columns of X86ImmSize.inc).