-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New architecture: BPF #1388
New architecture: BPF #1388
Conversation
wow nice work! let me go thru the code & give some comments |
the code looks very clean, you did an amazing job! @HarDToBelieve @catenacyber this also updates your regression testsuite & fuzzer, please ack. |
Few more comments:
|
@@ -189,14 +189,24 @@ static struct platform platforms[] = { | |||
CS_MODE_BIG_ENDIAN, | |||
"tms320c64x" | |||
}, | |||
#if CS_NEXT_VERSION >= 5 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the ifdef needs to remain so that both next
and master
branch can be fuzzed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh I found both master and next branch has the same CS_NEXT_VERSION = 5
, that's why I removed it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok thanks @david942j so your code is good
@aquynh how can a program know at compile time which architectures are supported by the current capstone ie branch master
and branch next
?
Great ! Cheers @david942j |
merged, thanks for this amazing work! |
@david942j, i had a commit to print out BPF for |
Oops I missed it, thanks! |
closes #838
Berkeley Packet Filter
CS_MODE_BPF_CLASSIC, CS_MODE_BPF_EXTENDED
)references: