-
Notifications
You must be signed in to change notification settings - Fork 253
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix CI failures by running Ruby <= 2.2 on older Ubuntu image #516
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,14 +1,14 @@ | ||
name: test on CI | ||
on: | ||
push: | ||
branches: [ master ] | ||
branches: [master] | ||
pull_request: | ||
jobs: | ||
test: | ||
runs-on: ubuntu-latest | ||
strategy: | ||
matrix: | ||
ruby: [ "2.0", "2.1", "2.2", "2.3", "2.4", "2.5", "2.6", "2.7", "3.0", "3.1", "3.2", "head" ] | ||
ruby: ["2.3", "2.4", "2.5", "2.6", "2.7", "3.0", "3.1", "3.2", "head"] | ||
steps: | ||
- uses: actions/checkout@v3 | ||
- name: Set up Ruby | ||
|
@@ -19,6 +19,33 @@ jobs: | |
- name: Run tests | ||
run: bundle exec rake test:units | ||
|
||
test-legacy: | ||
runs-on: ubuntu-20.04 | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🗒️ Use the older Ubuntu runner that is compatible with Ruby |
||
strategy: | ||
matrix: | ||
ruby: ["2.0", "2.1", "2.2"] | ||
steps: | ||
- uses: actions/checkout@v3 | ||
- name: Set up Ruby | ||
uses: ruby/setup-ruby@v1 | ||
with: | ||
ruby-version: ${{ matrix.ruby }} | ||
bundler-cache: true | ||
- name: Run tests | ||
run: bundle exec rake test:units | ||
|
||
test-all: | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🗒️ This aggregates all of the |
||
runs-on: ubuntu-latest | ||
needs: [test, test-legacy] | ||
if: always() | ||
steps: | ||
- name: All tests ok | ||
if: ${{ !(contains(needs.*.result, 'failure')) }} | ||
run: exit 0 | ||
- name: Some tests failed | ||
if: ${{ contains(needs.*.result, 'failure') }} | ||
run: exit 1 | ||
|
||
rubocop: | ||
runs-on: ubuntu-latest | ||
steps: | ||
|
@@ -35,7 +62,21 @@ jobs: | |
runs-on: macos-12 | ||
strategy: | ||
matrix: | ||
ruby: [ "2.0", "2.1", "2.2", "2.3", "2.4", "2.5", "2.6", "2.7", "3.0", "3.1", "3.2", "head" ] | ||
ruby: | ||
[ | ||
"2.0", | ||
"2.1", | ||
"2.2", | ||
"2.3", | ||
"2.4", | ||
"2.5", | ||
"2.6", | ||
"2.7", | ||
"3.0", | ||
"3.1", | ||
"3.2", | ||
"head", | ||
] | ||
steps: | ||
- uses: actions/checkout@v3 | ||
|
||
|
@@ -58,3 +99,15 @@ jobs: | |
|
||
- name: Run functional tests | ||
run: bundle exec rake test:functional | ||
|
||
functional-all: | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🗒️ Likewise this aggregates all the |
||
runs-on: ubuntu-latest | ||
needs: [functional] | ||
if: always() | ||
steps: | ||
- name: All tests ok | ||
if: ${{ !(contains(needs.*.result, 'failure')) }} | ||
run: exit 0 | ||
- name: Some tests failed | ||
if: ${{ contains(needs.*.result, 'failure') }} | ||
run: exit 1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🗒️
"2.0", "2.1", "2.2"
have been moved to the newtest-legacy
job.