do not prefix exec

[dreyks]

exec is a shell builtin so /usr/bin/env exec results in /usr/bin/env: exec: No such file or directory

[leehambley]

Thanks for the patch! Do you have a list of which shells have this as a prefix? I'm not sure it's universal, maybe POSIX spec has more details? If it's not 100% universal we can't merge this! (Sent from my Nexus 6, please forgive typos!)

…

On Nov 24, 2016 11:09, "Roman Usherenko" ***@***.***> wrote: exec is a shell builtin so /usr/bin/env exec results in /usr/bin/env: exec: No such file or directory ------------------------------ You can view, comment on, or merge this pull request online at: #378 Commit Summary - do not prefix exec File Changes - *M* lib/sshkit/command_map.rb <https://github.com/capistrano/sshkit/pull/378/files#diff-0> (2) Patch Links: - https://github.com/capistrano/sshkit/pull/378.patch - https://github.com/capistrano/sshkit/pull/378.diff — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#378>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AABKCMyLImSnhRO1NNquQf0-cnerMxOeks5rBXBSgaJpZM4K7iJt> .

[dreyks]

There's no binary named exec. just like there's no test binary. If some shell does not have such builtin it will fail regardless of whether it is prepended by /usr/bin/env or not

[leehambley]

There's no binary named exec. just like there's no test binary.

I know, but thanks for the clarification.

If some shell does not have such builtin it will fail regardless of whether it is prepended by /usr/bin/env or not

Couldn't find that in the POSIX spec, maybe you can. The command map exists for mapping commands where the defaults don't suit you.

[dreyks]

well, i don't completely understand why did you close this
right now if you use :exec it will get prepended by prefix and will fail for everyone. with my change it will work for those shells that have exec

[dreyks]

oh you updated your comment. i'll look at some shells and will give you examples

[leehambley]

oh you updated your comment. i'll look at some shells and will give you examples

Sorry, mis-clicked before I'd finished answering your feedback.

[dreyks]

this is what i found

http://pubs.opengroup.org/onlinepubs/007904875/idx/sbi.html

not completely sure this is what you mean but seems like every posix-compliant shell has to implement these

[leehambley]

Good find, according to Wikipedia:

Originally, the name "POSIX" referred to IEEE Std 1003.1-1988, released in 1988. The family of POSIX standards is formally designated as IEEE 1003 and the international standard name is ISO/IEC 9945.

So the document you linked was correct.

[leehambley]

Please update this PR with an entry in the CHANGELOG and to credit yourself, and I'll be happy to merge it. Thanks for your patience.

Edit: or let me know that you don't want to be credit, and just fix the changelog and I'll merge it

[dreyks]

🍏

updated my journal Changelog