Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use webui API in NMS #619

Merged
merged 18 commits into from
Aug 2, 2024
Merged

feat: use webui API in NMS #619

merged 18 commits into from
Aug 2, 2024

Conversation

patriciareinoso
Copy link
Contributor

@patriciareinoso patriciareinoso commented Jun 27, 2024

Description

This PR removes the internal NMS backend and have the client interface query the webui API directly.

Breaking change. It uses new Rock version 1.0.0

  • Remove all the files under pages/, which correspond to the internal NMS backend.
  • Create call*Api.tsx files, which contain the calls to the webui API (subscribers, networks slices and device groups).
  • Update URL to fetch the gnb and the upf list, which is now served by the webui.
  • Update URL to fetch the swagger UI, which is now served by the webui.
  • Change next.config.js : it contains the configuration to export the NMS into static files when building. Parameters that are no longer necessary were removed.
  • Redirection from / to /network-configuration is placed on app/page.tsx
  • Remove files not used: DeleteSubscriberButton.tsx, checkNetworkSliceExists.tsx
  • Rename to Aether SD-Core
  • Disable API link while waiting for feat: Add swagger UI omec-project/webconsole#193

This PR depends on the following PRs:

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code.
  • I have made corresponding changes to the documentation.
  • I have added tests that validate the behaviour of the software.
  • I validated that new and existing unit tests pass locally with my changes.
  • Any dependent changes have been merged and published in downstream modules.

Copy link
Contributor

@gatici gatici left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Minor things are commented for improvement.

utils/getNetworkSlice.tsx Outdated Show resolved Hide resolved
utils/callDeviceGroupApi.tsx Outdated Show resolved Hide resolved
utils/callDeviceGroupApi.tsx Outdated Show resolved Hide resolved
utils/callDeviceGroupApi.tsx Outdated Show resolved Hide resolved
utils/callDeviceGroupApi.tsx Outdated Show resolved Hide resolved
utils/callNetworkSliceApi.tsx Outdated Show resolved Hide resolved
utils/callNetworkSliceApi.tsx Outdated Show resolved Hide resolved
utils/callNetworkSliceApi.tsx Outdated Show resolved Hide resolved
utils/callNetworkSliceApi.tsx Outdated Show resolved Hide resolved
@patriciareinoso patriciareinoso marked this pull request as ready for review July 31, 2024 13:36
@patriciareinoso patriciareinoso requested a review from a team as a code owner July 31, 2024 13:36
@patriciareinoso patriciareinoso merged commit 672d7f5 into main Aug 2, 2024
14 checks passed
@patriciareinoso patriciareinoso deleted the TELCO-1151-use-webui-api branch August 2, 2024 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants