generated from canonical/is-charms-template-repo
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[COS] Update cos-agent and libraries #141
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
addyess
force-pushed
the
KU-1264/cos-agent-update-0.10
branch
3 times, most recently
from
August 27, 2024 23:16
c9fbe44
to
409edb0
Compare
bschimke95
approved these changes
Aug 28, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, only questions
Also, seems like the integration tests are not happy for some reason. |
addyess
commented
Aug 28, 2024
addyess
commented
Aug 28, 2024
* migrates pydantic 2 structures and validators * removes pydantic 2 deprecation warnings * updates cos_agent libraries
addyess
force-pushed
the
KU-1264/cos-agent-update-0.10
branch
from
August 30, 2024 02:25
12a93e3
to
88324e4
Compare
addyess
force-pushed
the
KU-1264/cos-agent-update-0.10
branch
from
August 30, 2024 03:05
247d872
to
b0bbfc0
Compare
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Upgrade the cos_agent libraries to current without switching from pydanditc 2 since the libraries STILL support 1.*
Details