-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Certificates Refresh Controller - Control Plane #58
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mateoflorido
force-pushed
the
KU-1513/certs-control-plane
branch
from
September 26, 2024 16:26
d9e29da
to
7af6877
Compare
eaudetcobello
approved these changes
Sep 26, 2024
berkayoz
reviewed
Sep 27, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work! Did a first pass and left some comments.
berkayoz
approved these changes
Sep 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Important
This implementation depends on the work in canonical/k8s-snap#699
Overview
Create a new controller to handle refresh certificates for control plane nodes running on CAPI.
Rationale
We need to expose the certificate refresh functionality for control plane nodes without requiring a full rollout deployment, which would consume more resources. Instead, we leverage the business logic baked in
k8s-snap
to refresh the certificates in place, which allows us to refresh the self-signed certificates without the additional overhead or down time in the cluster.Changes
socat
timeout (0.5 seconds) to 5 seconds due to latency when creating new certificates.Further Information
Proposal 003 - #54