Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Certs Refresh Proposal #54

Merged
merged 3 commits into from
Oct 8, 2024
Merged

Conversation

mateoflorido
Copy link
Member

@mateoflorido mateoflorido commented Sep 9, 2024

Overview

This proposal outlines a plan for refreshing certificates on cluster machines managed by Canonical Kubernetes CAPI providers.

Copy link

@louiseschmidtgen louiseschmidtgen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You've put some great thought into this cert refresh proposal, thank you Mateo!
Posted a few questions that came to my mind while reviewing.

docs/002-refresh-certs.md Outdated Show resolved Hide resolved
docs/002-refresh-certs.md Outdated Show resolved Hide resolved
docs/002-refresh-certs.md Outdated Show resolved Hide resolved
docs/002-refresh-certs.md Outdated Show resolved Hide resolved
Copy link
Member

@berkayoz berkayoz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work, did a first pass

docs/002-refresh-certs.md Outdated Show resolved Hide resolved
docs/002-refresh-certs.md Outdated Show resolved Hide resolved
docs/002-refresh-certs.md Outdated Show resolved Hide resolved
docs/002-refresh-certs.md Outdated Show resolved Hide resolved
docs/002-refresh-certs.md Outdated Show resolved Hide resolved
docs/002-refresh-certs.md Outdated Show resolved Hide resolved
docs/002-refresh-certs.md Outdated Show resolved Hide resolved
docs/002-refresh-certs.md Outdated Show resolved Hide resolved
docs/002-refresh-certs.md Outdated Show resolved Hide resolved
docs/002-refresh-certs.md Outdated Show resolved Hide resolved
Copy link
Contributor

@bschimke95 bschimke95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, great work!

Copy link
Member

@berkayoz berkayoz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! Let's mark it as accepted before merging

@mateoflorido mateoflorido marked this pull request as ready for review October 7, 2024 14:00
@mateoflorido mateoflorido requested a review from a team as a code owner October 7, 2024 14:00
Copy link
Contributor

@bschimke95 bschimke95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bschimke95 bschimke95 merged commit 9d55458 into main Oct 8, 2024
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants