Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LXD cloud_tests: support more lxd image formats #482

Merged
merged 4 commits into from
Jul 9, 2020
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 25 additions & 8 deletions tests/cloud_tests/platforms/lxd/image.py
Original file line number Diff line number Diff line change
Expand Up @@ -76,19 +76,36 @@ def properties(self):
}

def export_image(self, output_dir):
"""Export image from lxd image store to (split) tarball on disk.
"""Export image from lxd image store to disk.

@param output_dir: dir to store tarballs in
@return_value: tuple of path to metadata tarball and rootfs tarball
@param output_dir: dir to store the exported image in
@return_value: tuple of path to metadata tarball and rootfs
paride marked this conversation as resolved.
Show resolved Hide resolved

Only the "split" image format with separate rootfs and metadata
files is supported, e.g:

71f171df[...]cd31.squashfs (could also be: .tar.xz or .tar.gz)
meta-71f171df[...]cd31.tar.xz

Combined images made by a single tarball are not supported.
"""
# pylxd's image export feature doesn't do split exports, so use cmdline
subp.subp(['lxc', 'image', 'export', self.pylxd_image.fingerprint,
output_dir], capture=True)
tarballs = [p for p in os.listdir(output_dir) if p.endswith('tar.xz')]
paride marked this conversation as resolved.
Show resolved Hide resolved
fp = self.pylxd_image.fingerprint
subp.subp(['lxc', 'image', 'export', fp, output_dir], capture=True)
image_files = [p for p in os.listdir(output_dir) if fp in p]

if len(image_files) != 2:
raise NotImplementedError(
"Image %s has unsupported format. "
"Expected 2 files, found %d: %s."
% (fp, len(image_files), ', '.join(image_files)))

metadata = os.path.join(
output_dir, next(p for p in tarballs if p.startswith('meta-')))
output_dir,
next(p for p in image_files if p.startswith('meta-')))
rootfs = os.path.join(
output_dir, next(p for p in tarballs if not p.startswith('meta-')))
output_dir,
next(p for p in image_files if not p.startswith('meta-')))
return (metadata, rootfs)

def import_image(self, metadata, rootfs):
Expand Down