Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LXD cloud_tests: support more lxd image formats #482

Merged
merged 4 commits into from
Jul 9, 2020
Merged

LXD cloud_tests: support more lxd image formats #482

merged 4 commits into from
Jul 9, 2020

Conversation

paride
Copy link
Contributor

@paride paride commented Jul 7, 2020

LP: #1886080

@blackboxsw blackboxsw requested a review from raharper July 7, 2020 15:23
raharper
raharper requested changes Jul 8, 2020
View reviewed changes
Copy link
Collaborator

@raharper raharper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if we should follow up with LXD folks on all of the different export formats we might encounter. I think typically the images we use come in one or two, but there may be more for future images we want to test with.

tests/cloud_tests/platforms/lxd/image.py Show resolved Hide resolved
tests/cloud_tests/platforms/lxd/image.py Show resolved Hide resolved
@paride
Copy link
Contributor Author

paride commented Jul 8, 2020

The latest revision I pushed should support any image format provided that it's split.

raharper
raharper approved these changes Jul 8, 2020
View reviewed changes
Copy link
Collaborator

@raharper raharper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks!

@paride paride force-pushed the new-lxd-image-export-format branch from f274045 to 998aa0f Compare July 9, 2020 08:46
@paride paride changed the title Adapt the LXD tests to the new lxd image export format LXD cloud_tests: support more lxd image formats Jul 9, 2020
@paride
Copy link
Contributor Author

paride commented Jul 9, 2020

I retitled the PR as it's really about supporting more formats rather than supporting a new format.

@raharper raharper merged commit e753141 into canonical:master Jul 9, 2020
@raharper raharper mentioned this pull request Jul 10, 2020
Merged
This was referenced May 10, 2023
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raharper raharper raharper approved these changes

Assignees

@raharper raharper

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@paride @raharper