-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update error pages #912
Update error pages #912
Conversation
Demo starting at https://canonical-com-912.demos.haus |
Codecov Report
@@ Coverage Diff @@
## canonical-com-refresh #912 +/- ##
======================================================
Coverage 60.34% 60.34%
======================================================
Files 10 10
Lines 764 764
======================================================
Hits 461 461
Misses 303 303
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Other than that, LGTM. |
ready for another look. |
da47efa
to
eb6b20d
Compare
LGTM! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 with changes, please update the nested section to a strip
templates/404.html
Outdated
<img src="https://assets.ubuntu.com/v1/4de1c56c-404_v1.svg" alt="Error owl" width="400" height="400" /> | ||
<div class="p-strip"> | ||
<hr class="p-rule is-fixed-width"> | ||
<div class="row p-section"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we change this to a deep strip as well? Again, from Vanilla: "Sections should not be nested inside each other or inside the strips."
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes thanks
eb6b20d
to
5f9b49a
Compare
@lyubomir-popov FYI: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mtruj013 What do you think of this template? I couldn't use a partial cause the content was too rich but I thought this might do I used the .tmpl
format as specified in the docs https://jinja.palletsprojects.com/en/3.1.x/templates/#nesting-extends
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes! Make's total sense, let's do it!
@Sophie-32 Can you please review the writing on all the other error messages? |
|
We couldn't load this page. Try reloading or file an issue. Please note, this may be a known issue that we are working on. |
Thanks! Can you have a look at the other ones too? #912 (comment) |
You do not have access to this page. You can file a bug if this is an error. (Is there anything else the user can do in this case? Like contacting us? or requesting access?) |
Done
Rebuiuld the 404 page as per teh design (sans thge enrichment isometric illustration).
Driveby: Make footer stick to the bottom of the window.
QA
./run serve
Issue / Card
Fixes https://warthogs.atlassian.net/browse/WD-3807
Screenshots