Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update error pages #912

Merged
merged 5 commits into from
Jun 30, 2023
Merged

Conversation

lyubomir-popov
Copy link
Contributor

@lyubomir-popov lyubomir-popov commented Jun 24, 2023

Done

Rebuiuld the 404 page as per teh design (sans thge enrichment isometric illustration).
Driveby: Make footer stick to the bottom of the window.

QA

  • Check out this feature branch
  • Run the site using the command ./run serve
  • View the site locally in your web browser at: http://0.0.0.0:8002/
  • Run through the following QA steps
  • Check against hthe design

Issue / Card

Fixes https://warthogs.atlassian.net/browse/WD-3807

Screenshots

image

@webteam-app
Copy link

Demo starting at https://canonical-com-912.demos.haus

@codecov
Copy link

codecov bot commented Jun 24, 2023

Codecov Report

Merging #912 (0d9bd77) into canonical-com-refresh (d9fcb18) will not change coverage.
The diff coverage is n/a.

❗ Current head 0d9bd77 differs from pull request most recent head dba2b65. Consider uploading reports for the commit dba2b65 to get more accurate results

@@                  Coverage Diff                   @@
##           canonical-com-refresh     #912   +/-   ##
======================================================
  Coverage                  60.34%   60.34%           
======================================================
  Files                         10       10           
  Lines                        764      764           
======================================================
  Hits                         461      461           
  Misses                       303      303           
Flag Coverage Δ
python 60.34% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
webapp/static_data.py 100.00% <ø> (ø)

@lyubomir-popov lyubomir-popov changed the base branch from main to canonical-com-refresh June 24, 2023 22:52
@juanruitina
Copy link
Contributor

  • The link should be in "File a bug"
  • Second element should be a paragraph with H2 styling, not an H2.

Other than that, LGTM.

@lyubomir-popov
Copy link
Contributor Author

ready for another look.

@juanruitina
Copy link
Contributor

LGTM!

Copy link
Contributor

@mtruj013 mtruj013 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 with changes, please update the nested section to a strip

<img src="https://assets.ubuntu.com/v1/4de1c56c-404_v1.svg" alt="Error owl" width="400" height="400" />
<div class="p-strip">
<hr class="p-rule is-fixed-width">
<div class="row p-section">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we change this to a deep strip as well? Again, from Vanilla: "Sections should not be nested inside each other or inside the strips."

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes thanks

@ClementChaumel
Copy link
Contributor

@lyubomir-popov FYI:

401:
image

500:
image

502:
image

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mtruj013 What do you think of this template? I couldn't use a partial cause the content was too rich but I thought this might do I used the .tmpl format as specified in the docs https://jinja.palletsprojects.com/en/3.1.x/templates/#nesting-extends

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes! Make's total sense, let's do it!

@ClementChaumel ClementChaumel changed the title Wd 3807 dev 404 page Update error pages Jun 28, 2023
@juanruitina
Copy link
Contributor

@Sophie-32 Can you please review the writing on all the other error messages?

@lyubomir-popov
Copy link
Contributor Author

image
I would remove the breaks, and maybe @Sophie-32 can shorten the copy a bit? All else looks good, thanks @ClementChaumel

@Sophie-32
Copy link

We couldn't load this page.

Try reloading or file an issue.

Please note, this may be a known issue that we are working on.

@ClementChaumel
Copy link
Contributor

We couldn't load this page.

Try reloading or file an issue.

Please note, this may be a known issue that we are working on.

Thanks! Can you have a look at the other ones too? #912 (comment)

@Sophie-32
Copy link

(I'm not 100% clear on this kind of error, but suggest the following copy. In general, is there anything else a user can do when they get this issue like reloading etc)

image

Bad gateway

The proxy server did not get a valid response from an upstream server.

You can file a bug to report this issue.

@Sophie-32
Copy link

You do not have access to this page.

You can file a bug if this is an error.

(Is there anything else the user can do in this case? Like contacting us? or requesting access?)

@ClementChaumel ClementChaumel merged commit 08a307d into canonical-com-refresh Jun 30, 2023
8 checks passed
@ClementChaumel ClementChaumel deleted the WD-3807-dev-404-page branch June 30, 2023 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants