WD-14408 - add assets on /solutions/ubuntu-os #1372
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Demo
Jenkins 
demos.haus 
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1372 +/- ##
==========================================
- Coverage 72.48% 71.86% -0.62%
==========================================
Files 13 14 +1
Lines 1072 1102 +30
==========================================
+ Hits 777 792 +15
- Misses 295 310 +15
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
only comment I have is that the images here aren't the same height 
Lmk if I can help if it's an assets thing, but I'm using the comp just straight from the figma library so they should be correct aspect ratio |
|
@mattea-turic wouldn't this be a good candidate for the new equal-row-height--wrap variant? |
petesfrench
added
Review: QA +1
Review: Code +1 (with changes)
and removed
Review: Code needed
Review: QA needed
labels
Co-authored-by: Peter French <peter.french@canonical.com>
lizzochek
force-pushed
the
task/WD-14408
branch
from
b5c99e8
to
65204e3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Done
Added assets to the "Everywhere for everyone" section as per figma
QA
Issue / Card
WD-14408