-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wd 13776 Dev Refresh /data/mysql #1364
Wd 13776 Dev Refresh /data/mysql #1364
Conversation
Use same image from PostgreSQL page for 'easy to deploy and manage' section too please! |
Thew footer on the demo is on the right side, however design wireframe has it full width, @mattea-turic @Sophie-32 could you confirm how it should look? |
</div> | ||
<div class="col"> | ||
<div class="u-vertically-center u-aspect-ratio--16-9 p-image-wrapper u-container--background u-align--center p-strip"> | ||
<section class="p-section--hero"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please use the new hero layout from vanilla here: https://vanillaframework.io/docs/patterns/hero#2575-signpost It perfectly matches the pattern
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This would create an unwanted layout on medium screens
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe design will be better to confirm it here. @mattea-turic
templates/data/mysql.html
Outdated
<div class="col-6"> | ||
<p>"MySQL" is a trademark or registered trademark of Oracle. Other trademarks are property of their respective owners.</p> | ||
<hr /> | ||
<div class="u-text--muted col-start-large-7 col-6"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the copy doc it was asked to leave the footer as is. It was full width, not on the right
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried doing it with the full width and it would still use the 6-cols only and not the entire row.
So I did how we are doing on other pages of same bubble like canonical.com/data/mongodb
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe design should also confirm this @mattea-turic
I noticed we've got the same "blurriness" issue as we did for one of the other pages. I've added the isometrics to a new server, using the same method that solved it previously i.e. export @2x, no underlay. Can find them here: https://assets.ubuntu.com/manager?tag=mysql-and-postgres I can't remember if this was a problem for the postgres page too, but if so, would you be able to update the assets there too when you have time? I've also added an updated image so that the illustration doesn't occupy so much space. This is in same server as above, but here's link anyways |
Should be on right side to align with the other pages |
Done
QA
./run serve
Issue / Card
Fixes # WD-13776
Screenshots
[if relevant, include a screenshot]