Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WD-13772 Refresh /data/postgresql #1362

Merged

Conversation

immortalcodes
Copy link
Member

@immortalcodes immortalcodes commented Sep 3, 2024

Done

  • Refreshed /data/postgresql

QA

Issue / Card

Fixes # WD-13772

@webteam-app
Copy link

@mattea-turic
Copy link
Collaborator

Logo section here needs a couple of changes. The google cloud logo is deprecated, so pls use this one instead. Also, MAAS logo is different size from the MicroCloud logo, so just be sure to use this one, taken from the "logo-library-07-24-updated" server

Screenshot 2024-09-04 at 15 22 04

For images with text underneath, pls use 24px padding like in the fiigma, just to add a bit of breathing room there.
Screenshot 2024-09-04 at 15 37 51

As you mentioned on MM, there's still an issue with the image under "PostgreSQL support", but I'll look into it. And pls remove the h5 "support" there.
Screenshot 2024-09-04 at 15 39 01

For this section, the latter three components have a bg that's too dark and there's a gap(?) between the bold line and the container, but I suppose this isn't an issue if bg colour is the same. Also, link under first comp should be entirely blue.
Screenshot 2024-09-04 at 15 41 35

Copy link
Contributor

@britneywwc britneywwc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some small change suggestions

templates/data/postgresql.html Outdated Show resolved Hide resolved
templates/data/postgresql.html Outdated Show resolved Hide resolved
templates/data/postgresql.html Outdated Show resolved Hide resolved
templates/data/postgresql.html Outdated Show resolved Hide resolved
templates/data/postgresql.html Outdated Show resolved Hide resolved
templates/data/postgresql.html Show resolved Hide resolved
@immortalcodes
Copy link
Member Author

Logo section here needs a couple of changes. The google cloud logo is deprecated, so pls use this one instead. Also, MAAS logo is different size from the MicroCloud logo, so just be sure to use this one, taken from the "logo-library-07-24-updated" server

Screenshot 2024-09-04 at 15 22 04 For images with text underneath, pls use 24px padding like in the fiigma, just to add a bit of breathing room there. Screenshot 2024-09-04 at 15 37 51

As you mentioned on MM, there's still an issue with the image under "PostgreSQL support", but I'll look into it. And pls remove the h5 "support" there. Screenshot 2024-09-04 at 15 39 01

For this section, the latter three components have a bg that's too dark and there's a gap(?) between the bold line and the container, but I suppose this isn't an issue if bg colour is the same. Also, link under first comp should be entirely blue. Screenshot 2024-09-04 at 15 41 35

If I remove the highlight class, this is what I get. The latter images have a background of their own and hence we see difference in colors and a space between the line
image

The text for the first image has 2 different links, I couldn't have one of them over whole text.

Copy link
Contributor

@britneywwc britneywwc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work, thanks for making the changes! 🎉

@immortalcodes immortalcodes merged commit 577e7bb into main Sep 6, 2024
9 checks passed
@immortalcodes immortalcodes deleted the WD-13772-dev-refresh-https-canonical-com-data-postgresql branch September 6, 2024 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants