Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Only close the navigation when resizing horizontally #1344

Merged
merged 2 commits into from
Aug 14, 2024

Conversation

petesfrench
Copy link
Contributor

@petesfrench petesfrench commented Aug 14, 2024

Done

  • Adds logic to only close the navigation when resizing horizontally. For context: Vanilla added this the feature to close when resizing as there was still some issue going fluidly from mobile to desktop. This was causing a bug on mobile when you scrolled down and the search hid itself.

QA

  • Open the demo on a mobile device with chrome
  • Open then navigation and going to a section which is scroll-able (Products > Private cloud, for ex.)
  • Start to scroll down to reveal the rest of the navigation and causing the search bar to hide itself.
  • See that the navigation stays open.
  • Check that the navigation closes on horizontal resize on desktop.

Issue / Card

Fixes https://warthogs.atlassian.net/browse/WD-14167

@webteam-app
Copy link

@petesfrench petesfrench merged commit 9da084e into canonical-navigation Aug 14, 2024
9 checks passed
@petesfrench petesfrench deleted the wd-14167 branch August 14, 2024 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants