Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Smaller VM instructions #1006

Merged
merged 8 commits into from
Apr 18, 2024
Merged

Smaller VM instructions #1006

merged 8 commits into from
Apr 18, 2024

Conversation

JonasWanke
Copy link
Member

@JonasWanke JonasWanke commented Apr 4, 2024

This reduces Instruction from 72 to 16 bytes

Checklist

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

This reduces Instruction from 72 to 64 bytes
@JonasWanke JonasWanke added the T: Performance Type: Performance Improvements label Apr 4, 2024
@jwbot jwbot added the P: Compiler: VM Package: The VM executing Candy byte code (LIR) label Apr 4, 2024
@jwbot
Copy link
Collaborator

jwbot commented Apr 4, 2024

🐰Bencher

ReportThu, April 4, 2024 at 16:47:17 UTC
ProjectCandy
Branchsmaller-vm-instructions
TestbedGitHub Actions: Ubuntu 22.04
BenchmarkEstimated CyclesEstimated Cycles Results
estimated cycles
InstructionsInstructions Results
instructions
L1 AccessesL1 Accesses Results
accesses
L2 AccessesL2 Accesses Results
accesses
RAM AccessesRAM Accesses Results
accesses
Total AccessesTotal Accesses Results
total-accesses
compile: Examples/fibonacci.candy ➖ (view plot)1790821813.000➖ (view plot)1188992836.000➖ (view plot)1617831088.000➖ (view plot)10736027.000➖ (view plot)3408874.000➖ (view plot)1631975989.000
compile: Examples/helloWorld.candy ➖ (view plot)283828043.000➖ (view plot)175962913.000➖ (view plot)247710093.000➖ (view plot)1468750.000➖ (view plot)822120.000➖ (view plot)250000963.000
vm_runtime: Examples/fibonacci.candy 10➖ (view plot)183669009.000➖ (view plot)107520491.000➖ (view plot)151625779.000➖ (view plot)795598.000➖ (view plot)801864.000➖ (view plot)153223241.000
vm_runtime: Examples/helloWorld.candy ➖ (view plot)154530682.000➖ (view plot)88655964.000➖ (view plot)124991912.000➖ (view plot)692411.000➖ (view plot)745049.000➖ (view plot)126429372.000

Bencher - Continuous Benchmarking
View Public Perf Page
Docs | Repo | Chat | Help

This reduces Instruction from 64 to 40 bytes
This reduces Instruction from 40 to 24 bytes
This reduces Instruction from 24 to 16 bytes
@jwbot
Copy link
Collaborator

jwbot commented Apr 4, 2024

The golden IRs have changed: 73df643..cb7b645

@JonasWanke JonasWanke marked this pull request as ready for review April 4, 2024 16:46
@jwbot jwbot enabled auto-merge April 4, 2024 16:46
@jwbot jwbot merged commit 8c4d446 into main Apr 18, 2024
15 checks passed
@jwbot jwbot deleted the smaller-vm-instructions branch April 18, 2024 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P: Compiler: VM Package: The VM executing Candy byte code (LIR) T: Performance Type: Performance Improvements
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants