Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compatibility issues with Python 3.11 #24

Merged
merged 1 commit into from
May 12, 2022
Merged

Conversation

jirihnidek
Copy link
Collaborator

@jirihnidek jirihnidek commented May 11, 2022

@jirihnidek
Copy link
Collaborator Author

/packit build

@packit-as-a-service
Copy link

No config file for packit (e.g. .packit.yaml) found in candlepin/python-iniparse on commit 9cb34c2

For more info, please check out the documentation: https://packit.dev/docs/packit-service or contact us - Packit team

@ptoscano
Copy link
Contributor

Sounds good to me.

One small thing I'd change is in the commit message: if you replace

* Issue: https://github.com/candlepin/python-iniparse/issues/23

with e.g.

Closes #nnn

(or Resolves, or Fixes) then the merging of the commit will automatically close the referenced issue.

* Fixes: #23
* BZ: https://bugzilla.redhat.com/show_bug.cgi?id=2019017
* Replaced few deprecated methods with new methods
@jirihnidek
Copy link
Collaborator Author

Sounds good to me.

One small thing I'd change is in the commit message: if you replace

* Issue: https://github.com/candlepin/python-iniparse/issues/23

with e.g.

Closes #nnn

(or Resolves, or Fixes) then the merging of the commit will automatically close the referenced issue.

Fixed

Copy link
Contributor

@ptoscano ptoscano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace deprecated ConfigParser readfp and unittest aliases for Python 3.12
2 participants