Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(sqs): fail fast when queue does not exist #3415

Merged
merged 2 commits into from
Oct 1, 2024
Merged

fix(sqs): fail fast when queue does not exist #3415

merged 2 commits into from
Oct 1, 2024
+48 −0

Conversation

chillleader
Copy link
Member

@chillleader chillleader commented Oct 1, 2024 •
edited
Loading

Description

This PR adds a check on the SQS inbound connector startup to handle cases when the queue doesn't exist.

Related issues

related #3405

Checklist

  • PR has a milestone or the no milestone label.

@chillleader chillleader added this to the 8.6.0 milestone Oct 1, 2024
@chillleader chillleader self-assigned this Oct 1, 2024
@chillleader chillleader requested a review from a team as a code owner October 1, 2024 13:26
@chillleader chillleader mentioned this pull request Oct 1, 2024
Open
mathias-vandaele
mathias-vandaele previously approved these changes Oct 1, 2024
View reviewed changes
Copy link
Contributor

@mathias-vandaele mathias-vandaele left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work 👍

@johnBgood johnBgood modified the milestones: 8.6.0, 8.6.1 Oct 1, 2024
@chillleader chillleader added this pull request to the merge queue Oct 1, 2024
Merged via the queue into main with commit 949a742 Oct 1, 2024
10 checks passed
@chillleader chillleader deleted the sqs-consumer-fail-fast branch October 1, 2024 14:16
@sbuettner
Copy link
Contributor

Backport failed for release/8.3, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin release/8.3
git worktree add -d .worktree/backport-3415-to-release/8.3 origin/release/8.3
cd .worktree/backport-3415-to-release/8.3
git switch --create backport-3415-to-release/8.3
git cherry-pick -x 949a7429896189911cd4499f2b8e468e5a26d9ca

@sbuettner
Copy link
Contributor

Backport failed for release/8.4, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin release/8.4
git worktree add -d .worktree/backport-3415-to-release/8.4 origin/release/8.4
cd .worktree/backport-3415-to-release/8.4
git switch --create backport-3415-to-release/8.4
git cherry-pick -x 949a7429896189911cd4499f2b8e468e5a26d9ca

@sbuettner
Copy link
Contributor

Backport failed for release/8.5, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin release/8.5
git worktree add -d .worktree/backport-3415-to-release/8.5 origin/release/8.5
cd .worktree/backport-3415-to-release/8.5
git switch --create backport-3415-to-release/8.5
git cherry-pick -x 949a7429896189911cd4499f2b8e468e5a26d9ca

sbuettner pushed a commit that referenced this pull request Oct 1, 2024
@chillleader @github-actions
fix(sqs): fail fast when queue does not exist (#3415)
eb187e3 
* fix(sqs): fail fast when queue does not exist

* fix tests

(cherry picked from commit 949a742)
@sbuettner
Copy link
Contributor

Successfully created backport PR for release/8.6:

@sbuettner sbuettner mentioned this pull request Oct 1, 2024
Merged
@sbuettner
Copy link
Contributor

Backport failed for release/8.3, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin release/8.3
git worktree add -d .worktree/backport-3415-to-release/8.3 origin/release/8.3
cd .worktree/backport-3415-to-release/8.3
git switch --create backport-3415-to-release/8.3
git cherry-pick -x 949a7429896189911cd4499f2b8e468e5a26d9ca

1 similar comment
@sbuettner
Copy link
Contributor

Backport failed for release/8.3, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin release/8.3
git worktree add -d .worktree/backport-3415-to-release/8.3 origin/release/8.3
cd .worktree/backport-3415-to-release/8.3
git switch --create backport-3415-to-release/8.3
git cherry-pick -x 949a7429896189911cd4499f2b8e468e5a26d9ca

@sbuettner
Copy link
Contributor

Backport failed for release/8.4, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin release/8.4
git worktree add -d .worktree/backport-3415-to-release/8.4 origin/release/8.4
cd .worktree/backport-3415-to-release/8.4
git switch --create backport-3415-to-release/8.4
git cherry-pick -x 949a7429896189911cd4499f2b8e468e5a26d9ca

@sbuettner
Copy link
Contributor

Backport failed for release/8.3, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin release/8.3
git worktree add -d .worktree/backport-3415-to-release/8.3 origin/release/8.3
cd .worktree/backport-3415-to-release/8.3
git switch --create backport-3415-to-release/8.3
git cherry-pick -x 949a7429896189911cd4499f2b8e468e5a26d9ca

1 similar comment
@sbuettner
Copy link
Contributor

Backport failed for release/8.3, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin release/8.3
git worktree add -d .worktree/backport-3415-to-release/8.3 origin/release/8.3
cd .worktree/backport-3415-to-release/8.3
git switch --create backport-3415-to-release/8.3
git cherry-pick -x 949a7429896189911cd4499f2b8e468e5a26d9ca

@sbuettner
Copy link
Contributor

You have exceeded a secondary rate limit and have been temporarily blocked from content creation. Please retry your request again later.

@sbuettner
Copy link
Contributor

Backport failed for release/8.3, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin release/8.3
git worktree add -d .worktree/backport-3415-to-release/8.3 origin/release/8.3
cd .worktree/backport-3415-to-release/8.3
git switch --create backport-3415-to-release/8.3
git cherry-pick -x 949a7429896189911cd4499f2b8e468e5a26d9ca

@sbuettner
Copy link
Contributor

Backport failed for release/8.4, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin release/8.4
git worktree add -d .worktree/backport-3415-to-release/8.4 origin/release/8.4
cd .worktree/backport-3415-to-release/8.4
git switch --create backport-3415-to-release/8.4
git cherry-pick -x 949a7429896189911cd4499f2b8e468e5a26d9ca

1 similar comment
@sbuettner
Copy link
Contributor

Backport failed for release/8.4, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin release/8.4
git worktree add -d .worktree/backport-3415-to-release/8.4 origin/release/8.4
cd .worktree/backport-3415-to-release/8.4
git switch --create backport-3415-to-release/8.4
git cherry-pick -x 949a7429896189911cd4499f2b8e468e5a26d9ca

@sbuettner
Copy link
Contributor

Backport failed for release/8.3, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin release/8.3
git worktree add -d .worktree/backport-3415-to-release/8.3 origin/release/8.3
cd .worktree/backport-3415-to-release/8.3
git switch --create backport-3415-to-release/8.3
git cherry-pick -x 949a7429896189911cd4499f2b8e468e5a26d9ca

@sbuettner
Copy link
Contributor

Backport failed for release/8.4, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin release/8.4
git worktree add -d .worktree/backport-3415-to-release/8.4 origin/release/8.4
cd .worktree/backport-3415-to-release/8.4
git switch --create backport-3415-to-release/8.4
git cherry-pick -x 949a7429896189911cd4499f2b8e468e5a26d9ca

@sbuettner
Copy link
Contributor

Backport failed for release/8.3, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin release/8.3
git worktree add -d .worktree/backport-3415-to-release/8.3 origin/release/8.3
cd .worktree/backport-3415-to-release/8.3
git switch --create backport-3415-to-release/8.3
git cherry-pick -x 949a7429896189911cd4499f2b8e468e5a26d9ca

@sbuettner
Copy link
Contributor

Backport failed for release/8.5, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin release/8.5
git worktree add -d .worktree/backport-3415-to-release/8.5 origin/release/8.5
cd .worktree/backport-3415-to-release/8.5
git switch --create backport-3415-to-release/8.5
git cherry-pick -x 949a7429896189911cd4499f2b8e468e5a26d9ca

@sbuettner
Copy link
Contributor

Backport failed for release/8.4, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin release/8.4
git worktree add -d .worktree/backport-3415-to-release/8.4 origin/release/8.4
cd .worktree/backport-3415-to-release/8.4
git switch --create backport-3415-to-release/8.4
git cherry-pick -x 949a7429896189911cd4499f2b8e468e5a26d9ca

@sbuettner
Copy link
Contributor

Backport failed for release/8.5, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin release/8.5
git worktree add -d .worktree/backport-3415-to-release/8.5 origin/release/8.5
cd .worktree/backport-3415-to-release/8.5
git switch --create backport-3415-to-release/8.5
git cherry-pick -x 949a7429896189911cd4499f2b8e468e5a26d9ca

1 similar comment
@sbuettner
Copy link
Contributor

Backport failed for release/8.5, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin release/8.5
git worktree add -d .worktree/backport-3415-to-release/8.5 origin/release/8.5
cd .worktree/backport-3415-to-release/8.5
git switch --create backport-3415-to-release/8.5
git cherry-pick -x 949a7429896189911cd4499f2b8e468e5a26d9ca

@sbuettner
Copy link
Contributor

Backport failed for release/8.4, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin release/8.4
git worktree add -d .worktree/backport-3415-to-release/8.4 origin/release/8.4
cd .worktree/backport-3415-to-release/8.4
git switch --create backport-3415-to-release/8.4
git cherry-pick -x 949a7429896189911cd4499f2b8e468e5a26d9ca

1 similar comment
@sbuettner
Copy link
Contributor

Backport failed for release/8.4, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin release/8.4
git worktree add -d .worktree/backport-3415-to-release/8.4 origin/release/8.4
cd .worktree/backport-3415-to-release/8.4
git switch --create backport-3415-to-release/8.4
git cherry-pick -x 949a7429896189911cd4499f2b8e468e5a26d9ca

@sbuettner
Copy link
Contributor

Git push to origin failed for release/8.6 with exitcode 1

@sbuettner
Copy link
Contributor

Backport failed for release/8.5, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin release/8.5
git worktree add -d .worktree/backport-3415-to-release/8.5 origin/release/8.5
cd .worktree/backport-3415-to-release/8.5
git switch --create backport-3415-to-release/8.5
git cherry-pick -x 949a7429896189911cd4499f2b8e468e5a26d9ca

1 similar comment
@sbuettner
Copy link
Contributor

Backport failed for release/8.5, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin release/8.5
git worktree add -d .worktree/backport-3415-to-release/8.5 origin/release/8.5
cd .worktree/backport-3415-to-release/8.5
git switch --create backport-3415-to-release/8.5
git cherry-pick -x 949a7429896189911cd4499f2b8e468e5a26d9ca

@sbuettner
Copy link
Contributor

Git push to origin failed for release/8.6 with exitcode 1

@sbuettner
Copy link
Contributor

Backport failed for release/8.5, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin release/8.5
git worktree add -d .worktree/backport-3415-to-release/8.5 origin/release/8.5
cd .worktree/backport-3415-to-release/8.5
git switch --create backport-3415-to-release/8.5
git cherry-pick -x 949a7429896189911cd4499f2b8e468e5a26d9ca

chillleader added a commit that referenced this pull request Oct 1, 2024
@chillleader
fix(sqs): fail fast when queue does not exist (#3415)
979c61e 
* fix(sqs): fail fast when queue does not exist

* fix tests

(cherry picked from commit 949a742)
chillleader added a commit that referenced this pull request Oct 1, 2024
@sbuettner @chillleader
fix(sqs): fail fast when queue does not exist (#3415) (#3417)
9e4e14c 
* fix(sqs): fail fast when queue does not exist

* fix tests

(cherry picked from commit 949a742)

Co-authored-by: Pavel Kotelevsky <38818382+chillleader@users.noreply.github.com>
chillleader added a commit that referenced this pull request Oct 1, 2024
@chillleader
fix(sqs): fail fast when queue does not exist (#3415)
f540c57 
* fix(sqs): fail fast when queue does not exist

* fix tests

(cherry picked from commit 949a742)
chillleader added a commit that referenced this pull request Oct 1, 2024
@chillleader
fix(sqs): fail fast when queue does not exist (#3415)
63b381a 
* fix(sqs): fail fast when queue does not exist

* fix tests

(cherry picked from commit 949a742)
This was referenced Oct 1, 2024
Merged
Merged
Merged
ev-codes pushed a commit that referenced this pull request Oct 1, 2024
@chillleader
fix(sqs): fail fast when queue does not exist (#3415) (#3422)
a0acfef 
* fix(sqs): fail fast when queue does not exist (#3415)

* fix(sqs): fail fast when queue does not exist

* fix tests

(cherry picked from commit 949a742)

* fix syntax
ev-codes pushed a commit that referenced this pull request Oct 1, 2024
@chillleader
fix(sqs): fail fast when queue does not exist (#3415) (#3420)
144c075 
* fix(sqs): fail fast when queue does not exist (#3415)

* fix(sqs): fail fast when queue does not exist

* fix tests

(cherry picked from commit 949a742)

* fix syntax
ev-codes pushed a commit that referenced this pull request Oct 1, 2024
@chillleader
fix(sqs): fail fast when queue does not exist (#3415) (#3421)
6ebada2 
* fix(sqs): fail fast when queue does not exist (#3415)

* fix(sqs): fail fast when queue does not exist

* fix tests

(cherry picked from commit 949a742)

* fix syntax
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johnBgood johnBgood johnBgood approved these changes

@mathias-vandaele mathias-vandaele mathias-vandaele left review comments

Assignees

@chillleader chillleader

Labels
backport release/8.3 backport release/8.4 backport release/8.5 backport release/8.6
Projects
None yet
Milestone
8.6.1
Development

Successfully merging this pull request may close these issues.
4 participants
@chillleader @sbuettner @johnBgood @mathias-vandaele