Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(email-connector): send emails will always make the process fail #3394

Merged
merged 1 commit into from
Sep 30, 2024
Merged

fix(email-connector): send emails will always make the process fail #3394

merged 1 commit into from
Sep 30, 2024

Conversation

mathias-vandaele
Copy link
Contributor

Description

Quick fix, the send email action will always fails if the mail cannot be sent

Related issues

closes #

Checklist

  • PR has a milestone or the no milestone label.

@mathias-vandaele mathias-vandaele requested a review from a team as a code owner September 30, 2024 13:41
@mathias-vandaele mathias-vandaele self-assigned this Sep 30, 2024
@mathias-vandaele mathias-vandaele added this to the 8.6.0 milestone Sep 30, 2024
@mathias-vandaele mathias-vandaele added this pull request to the merge queue Sep 30, 2024
Merged via the queue into main with commit 91ce206 Sep 30, 2024
12 of 14 checks passed
@mathias-vandaele mathias-vandaele deleted the send-email-should-always-fail-when-throwing branch September 30, 2024 14:13
sbuettner pushed a commit that referenced this pull request Sep 30, 2024
@mathias-vandaele @github-actions
fix(email-connector): send emails will always make the process fail (#…
475aed5 
…3394)

(cherry picked from commit 91ce206)
@sbuettner
Copy link
Contributor

Successfully created backport PR for release/8.6:

@sbuettner sbuettner mentioned this pull request Sep 30, 2024
Merged
mathias-vandaele added a commit that referenced this pull request Sep 30, 2024
@sbuettner @mathias-vandaele
fix(email-connector): send emails will always make the process fail (#…
ed4a411 
…3394) (#3395)

(cherry picked from commit 91ce206)

Co-authored-by: Mathias Vandaele <mathias.vandaele@camunda.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johnBgood johnBgood johnBgood approved these changes

Assignees

@mathias-vandaele mathias-vandaele

Labels
backport release/8.6
Projects
None yet
Milestone
8.6.0
Development

Successfully merging this pull request may close these issues.
3 participants
@mathias-vandaele @sbuettner @johnBgood