Underlying HTTP client evaluates system properties, e.g. proxy settin…

…gs (#943)
camunda-community-hub · Sep 24, 2024 · a185edd · a185edd
1 parent 3f1894c
commit a185edd
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 3 deletions.
diff --git a/camunda-sdk-java/java-common/src/main/java/io/camunda/common/auth/SaaSAuthentication.java b/camunda-sdk-java/java-common/src/main/java/io/camunda/common/auth/SaaSAuthentication.java
@@ -22,7 +22,7 @@ public static SaaSAuthenticationBuilder builder() {
   }
 
   private TokenResponse retrieveToken(Product product, JwtCredential jwtCredential) {
-    try (CloseableHttpClient client = HttpClients.createDefault()) {
+    try (CloseableHttpClient client = HttpClients.createSystem()) {
       HttpPost request = buildRequest(jwtCredential);
       return client.execute(
           request,

diff --git a/camunda-sdk-java/java-common/src/main/java/io/camunda/common/auth/SimpleAuthentication.java b/camunda-sdk-java/java-common/src/main/java/io/camunda/common/auth/SimpleAuthentication.java
@@ -32,7 +32,7 @@ public SimpleConfig getSimpleConfig() {
   }
 
   private Map<String, String> retrieveToken(Product product, SimpleCredential simpleCredential) {
-    try (CloseableHttpClient client = HttpClients.createDefault()) {
+    try (CloseableHttpClient client = HttpClients.createSystem()) {
       HttpPost request = buildRequest(simpleCredential);
 
       Map<String, String> headers =

diff --git a/camunda-sdk-java/java-common/src/main/java/io/camunda/common/http/DefaultHttpClient.java b/camunda-sdk-java/java-common/src/main/java/io/camunda/common/http/DefaultHttpClient.java
@@ -41,7 +41,7 @@ public class DefaultHttpClient implements HttpClient {
 
   public DefaultHttpClient(Authentication authentication) {
     this.authentication = authentication;
-    this.httpClient = HttpClients.createDefault();
+    this.httpClient = HttpClients.createSystem();
     this.jsonMapper = new SdkObjectMapper();
     this.productMap = new HashMap<>();
   }