Consolidation of changes related to session duration #296
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- For creation, duration is made required. Maximum and default are deprecated, relying on the QoS Profile API for any limit. Implementations can grant the requested duration or set a different value in the response. - maxDuration in QoS Profiles is assumed to be the absolute maximum duration including any extensions. That is, extensions can extend the current session duration to the maximumDuration but no longer. Session info changes: - dates are formatted as string, date-format. - startedAt and expiredAt are both optional and not expected to be returned when qosStatus is "REQUESTED". - duration is the overall session duration, including any extension. It should be the interval between startedAt and expiresAt, so it is redundant, unless the qosStatus is "REQUESTED". In this case it would reflect the requested or granted duration. For sessions with qosStatus = "UNAVAILABLE", it must be adjusted to the effective duration.
jlurien
requested review from
hdamker,
eric-murray and
RandyLevensalor
as code owners
Fixing linting complaints about trailing spaces
|
From a developer point of view this looks good. An internal PoC was successfully created. |
hdamker
reviewed
Jun 12, 2024
| Session duration in seconds. Implementations can grant the requested session duration or set a different duration, based on network policies or conditions. | ||
| - When `qosStatus` is "REQUESTED", the value is the duration to be scheduled, granted by the implementation. | ||
| - When `qosStatus` is AVAILABLE", the value is the overall duration since `startedAt. When the session is extended, the value is the new overall duration of the session. | ||
| - When `qosStatus` is "UNAVAILABLE", the value is the overall effective duration since `startedAt` until the session was terminated. | ||
| type: integer | ||
| format: int32 | ||
| minimum: 1 |
There was a problem hiding this comment.
Do we need this minimum definition? My proposal is to omit it: QoS profile is defining beside maxDuration also minDuration. From my perspective "Implementations can grant the requested session duration or set a different duration" applies also to the minimum.
There was a problem hiding this comment.
It only enforces that duration > 0 (no zero or negative values allowed). minDuration is optional in the QoS Profile. But any implementation would reject values <=0, even if this not explicitly added to the spec.
| - `qosStatus` as `UNAVAILABLE`, and, | ||
| - `statusInfo` as `DURATION_EXPIRED`. | ||
| See notification callback. | ||
| Requested session duration in seconds. Value may be explicitly limited for the QoS profile, as specified in the [Qos Profile API](TBC). Implementations can grant the requested session duration or set a different duration, based on network policies or conditions. | ||
| type: integer | ||
| format: int32 | ||
| minimum: 1 |
There was a problem hiding this comment.
Same comment as above. If the minimum is just meant to avoid negative values, I'm fine.
|
@eric-murray @RandyLevensalor Last meeting we discussed to merge if there are no objections. Do you have checked as well? |
eric-murray
approved these changes
Jun 13, 2024
RandyLevensalor
approved these changes
Jun 13, 2024
This was referenced Jun 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What this PR does / why we need it:
Clarification and consolidation of changes affecting management of session duration.
Session info changes:
Which issue(s) this PR fixes:
Fixes #291 #249 #266 #280 #281 #288
Special notes for reviewers:
Discussion in #291
Changelog input