Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duration in QoS Session and QoS Profile #266

Closed
gauravn00b opened this issue Feb 13, 2024 · 2 comments
Closed

Duration in QoS Session and QoS Profile #266

gauravn00b opened this issue Feb 13, 2024 · 2 comments
Labels
documentation Improvements or additions to documentation Fall24 Relevant for maintenance of Fall24 release

Comments

@gauravn00b
Copy link

Problem description
What is the co-relation between Duration in QoS Session and QoS Profile?

Expected action
Exact behavior should be mentioned, if either of two does not match.

Additional context
There is no clarity mentioned in documentation except it should not exceed 24 hours. However, there is no clarity if both does not match. for eg, if someone provide minduration as 3600 seconds in profile and provide duration as 1800 seconds in session creation, what should be the behaviour here? Or we should remove duration from session creation and rely only on profiles, as recommended in #249 as well

@gauravn00b gauravn00b added the documentation Improvements or additions to documentation label Feb 13, 2024
@hdamker
Copy link
Collaborator

hdamker commented Feb 14, 2024

@gauravn00b the duration requested within createSession is the session duration the API consumer wants to have for the session. It has to be between minDuration and maxDuration as defined within the qosProfile. These limits are defined by the service provider but they are only defining the lower (e.g. 10 seconds) and upper limit (e.g. 24 hours) but not the actual duration of a session.

The behaviour in cases where the requested duration is outside the range of minDuration and maxDuration we discussed in #247 and introduced the error example DurationOutOfRangeForQoSProfile (see #259).

If you have a proposal to describe the behavior better within the documentation feel free to open a PR.

#249 is about getting rid of the 24 hour limit within createSession (as we have now maxDuration in the qosProfile for that), and make the type of the values consistent. But duration will stay as parameter in createSession.

@hdamker
Copy link
Collaborator

hdamker commented Jun 14, 2024

Fixed in #296

@hdamker hdamker closed this as completed Jun 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation Fall24 Relevant for maintenance of Fall24 release
Projects
None yet
Development

No branches or pull requests

2 participants