-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add an “Area” data-type into CAMARA_common.yaml #242
Comments
@jlurien FYI for any consideration. Issue is going to be enhanced with more info. |
When creating an
|
@tlohmar I support the idea. In fact, when defining areas in RegionDeviceCount and NetworkSliceBooking, we referred to the definition of area in DeviceLocation due to the lack of a common definition. If 3GPP has a complete definition standard, I believe it is reasonable to follow 3GPP's definition to create a common definition for area. |
having a consistent representation of the same area is a good idea.
Besides this, there are two other issues which one need to decide: PS: regarding renaming suggested in the comment
TS 29.572 uses GeographicalCoordinateS (plural) |
Another source of inspiration for the data type could be objects defined by The GeoJSON Specification (RFC 7946). See: |
Completely aligned on having a consistent representation across our API. Now about the value itself I'm bit more mixed.
Could worth to have some discussion about keep it standard (and which standard?) vs keep simple. |
Our model in DeviceLocation is almost the same as 3GPP LMF Location API (TS29.572), but with different names. 3GPP PointUncertaintyCircle (point + uncertainty) is equivalent to our Circle (center + radius), and Polygon is also an array of coordinates delimiting the boundary (pointList vs boundary), both with length 3-15 (we copied the limit from them). GeoJson uses a more complex, and I would say less intuitive, model. Polygons for example are defined as an array of arrays of arrays, allowing the definition of polygons with holes. And Circles are not explicitly specified AFAIK. It would be good to include the common schemas in the common artifact and find some way to reference them from the specs. e.g. "$ref": "CAMARA_common.yaml#/components/schemas/XXX" |
Problem description
Multiple APIs are using a similar data type (a profiled variant) for describing an
Area
, which allows a description of a service area or geographical area in form of a circle and/or a polygon.Note, a similar ‘Area’ definition is also available in 3GPP (TS 29.572). There are some differences, like the data type is named GeographicArea or the PointList is a list of GeographicalCoordinates (no Points).
Expected action
The text was updated successfully, but these errors were encountered: