fix: correctly separate multiple scopes with '&'

[edwardgeorge]

was generating invalid query strings with multiple scopes, eg:

.authenticate(&["repository:foo:pull", "repository:bar:pull"])

is serialised as:

?service=...&scope=repository:foo:pullscope=repository:bar:pull

note the missing '&' between pull and scope.

[lucab]

@edwardgeorge good catch! If you don't mind, can you please add unit tests for the following three cases:

• no scopes
• one scope
• more than one scope

[edwardgeorge]

@lucab sure, no problem.

[edwardgeorge]

@lucab updated with three tests

[steveej]

Thank you @edwardgeorge for the tests and the bugfix!
The PR looks good to me. I'll leave it up to you if you want to use https://crates.io/crates/test-case to conflate these similar cases into a single test function declaration.
If you choose to do so, note that test-case doesn't support Result return types, i.e. it'll silently ignore errors and state that the test has passed. Which means you'd have to use unwrap instead of ?.
If you choose not to do so, let me know and I'll happily merge it 🙂

[edwardgeorge]

@steveej updated with consolidated, parametrized tests