feat: handle mode value to avoid signin error caused by 3pcd ✨ #834
+72
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: a964916 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
ejithon
commented
May 21, 2024
|
|
||
| const uriKey = Object.keys(schema.properties).find((key) => { | ||
| const property = schema.properties?.[key]; | ||
| return property?.type === 'string' && property.format === 'uri'; |
There was a problem hiding this comment.
We need to document this specification.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Due to third-party cookie blocking (3PCB), some users are currently experiencing failures in the OAuth sign-in flow.
To mitigate this, we have implemented a pattern that allows the authentication URL to be obtained within the Viron domain, ensuring the state is treated as a partitoned cookie.
Checklist