Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] feat: ModuleFederation 2.0 support #674

Draft
wants to merge 74 commits into
base: main
Choose a base branch
from

Conversation

jbroma
Copy link
Member

@jbroma jbroma commented Jul 26, 2024

Summary

Closes #518

Test plan

Copy link

changeset-bot bot commented Jul 26, 2024

⚠️ No Changeset found

Latest commit: 221bc47

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Jul 26, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
repack-website ⬜️ Ignored (Inspect) Visit Preview Oct 10, 2024 11:05pm

url = hookResult.url;
}
}
- let urlObj;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need to patch. You can PR my repo and add a react-native.ts to sdk. Then do whatever you need to do that can detect RN vs node and we can ship it under official.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wanted to showcase what was getting in the way. I would love to remove our custom MF plugin in the future and rely just on MF core 🤞

I can't think of a good way to differentiate RN from other envs though 🤔 one idea I had was to enhance the createScript hook, so we could patch the logic entirely. But I would rather keep the logic in MF altogether like you did with node

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

figured most things out, PR here: module-federation/core#2812

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adopt the new federation runtime
2 participants