Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: improve integration test suites #615

Merged
merged 7 commits into from
Jul 31, 2019
Merged

chore: improve integration test suites #615

merged 7 commits into from
Jul 31, 2019

Conversation

zamotany
Copy link
Contributor

No description provided.

@zamotany zamotany removed the wip ⚙ label Jul 30, 2019
Copy link
Member

@thymikee thymikee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

const path = require('path');
const mkdirp = require('mkdirp');
const rimraf = require('rimraf');
export const yarnCommand = process.platform === 'win32' ? 'yarn.cmd' : 'yarn';
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you should be able to avoid that using execa

integration_tests/utils/server.ts Show resolved Hide resolved
@zamotany zamotany merged commit 2c68e97 into next Jul 31, 2019
@zamotany zamotany deleted the chore/better-tests branch July 31, 2019 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants