Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

format version parts #26

Conversation

ichrysou
Copy link
Contributor

Apply fix as suggested here:
c4urself/bump2version#141

@codecov
Copy link

codecov bot commented Jun 30, 2023

Codecov Report

Merging #26 (ee43bdb) into master (173be1a) will increase coverage by 0.03%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master      #26      +/-   ##
==========================================
+ Coverage   92.10%   92.14%   +0.03%     
==========================================
  Files          15       15              
  Lines         963      967       +4     
  Branches      207      207              
==========================================
+ Hits          887      891       +4     
  Misses         48       48              
  Partials       28       28              
Flag Coverage Δ
python-3.10 92.14% <100.00%> (+0.03%) ⬆️
python-3.11 92.14% <100.00%> (+0.03%) ⬆️
python-3.8 92.14% <100.00%> (+0.03%) ⬆️
python-3.9 92.14% <100.00%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
bumpversion/__init__.py 100.00% <100.00%> (ø)
bumpversion/version_part.py 88.43% <100.00%> (+0.32%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@coordt coordt merged commit 978ac7a into callowayproject:master Jun 30, 2023
10 of 11 checks passed
@reindlt
Copy link

reindlt commented Apr 23, 2024

It seems that this fix was removed with some refactoring happened in #112. Tried with version 0.20.1 and the following config parameters:

current_version = "5.06.0"
parse = "(?P<major>\\d+)\\.(?P<minor>\\d+)\\.(?P<patch>\\d+)"
serialize = ["{major}.{minor:02}.{patch}"]
search = "{current_version}"
replace = "{new_version}"

Increasing minor would result in version 5.70.0 which is obviously wrong. Any chances we get this functionality back? Or is there any other possibility to have fixed length version numbers?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants