Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VersionNotFoundError does not always display the correct version serialization #20

Closed
coordt opened this issue Jun 14, 2023 · 0 comments · Fixed by #21
Closed

VersionNotFoundError does not always display the correct version serialization #20

coordt opened this issue Jun 14, 2023 · 0 comments · Fixed by #21

Comments

@coordt
Copy link
Member

coordt commented Jun 14, 2023

  • bump-my-version version: 0.5.0
  • Python version: 3.11
  • Operating System: MacOS

Description

When bump-my-version checks if the file contains the version, and it does not find it it raises an Exception. However it doesn't always display the correct serialized version it was looking for

What I Did

Modified test_issue_14 to call modify_files.
@coordt coordt mentioned this issue Jun 14, 2023
Closed
coordt added a commit that referenced this issue Jun 14, 2023
@coordt
Fixes reporting the wrong version missing in a file
efb04e9 
- Fixes issue #20
- Renders the correct `current_version` for each file being modified.
@coordt coordt linked a pull request Jun 14, 2023 that will close this issue
Fixes reporting the wrong version missing in a file #21
Merged
@coordt coordt mentioned this issue Jun 14, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixes reporting the wrong version missing in a file callowayproject/bump-my-version
1 participant
@coordt