Drop 2to3 setup option #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
n1ngu
requested changes
Feb 3, 2022
There was a problem hiding this comment.
I am afraid the commit message is very inaccurate: 2to3 is not a dependency that isn't required anymore, but a deprecated flag to the setuptools build backend.
And this flag ceased to be necessary long ago when this project was migrated to python3, now it just happens that latest setuptools versions featured in the CI jobs will not tolerate this ancient flag anymore.
GuillemCalidae
force-pushed
the
remove-2to3-dependency
branch
from
d41018c
to
0a878e4
Compare
New setuptools versions stop deliberately building packages that use 2to3. See pypa/setuptools#2769 This option should have been removed in commit 3aeb6ff
GuillemCalidae
changed the title
GuillemCalidae
force-pushed
the
remove-2to3-dependency
branch
from
0a878e4
to
0fb2494
Compare
n1ngu
approved these changes
Feb 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New setuptools versions stop deliberately building packages that use 2to3. See pypa/setuptools#2769
This option should have been removed in commit 3aeb6ff