fix(copy): clear array destinations correctly for non-array sources

Closes angular#8610
caitp · Aug 21, 2014 · 6817c89 · 6817c89
1 parent 0872388
commit 6817c89
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 0 deletions.
diff --git a/src/Angular.js b/src/Angular.js
@@ -803,6 +803,7 @@ function copy(source, destination, stackSource, stackDest) {
       forEach(destination, function(value, key) {
         delete destination[key];
       });
+      if (isArray(destination)) destination.length = 0;
       for ( var key in source) {
         if(source.hasOwnProperty(key)) {
           result = copy(source[key], null, stackSource, stackDest);

diff --git a/test/AngularSpec.js b/test/AngularSpec.js
@@ -184,6 +184,12 @@ describe('angular', function() {
       expect(aCopy).toBe(aCopy.self);
       expect(aCopy.selfs[2]).not.toBe(a.selfs[2]);
     });
+
+    it('should clear destination arrays correctly when source is non-array', function() {
+      expect(copy(null, [1,2,3])).toEqual([]);
+      expect(copy(undefined, [1,2,3])).toEqual([]);
+      expect(copy({0: 1, 1: 2}, [1,2,3])).toEqual([1,2]);
+    });
   });
 
   describe("extend", function() {