DP-516 - SupplierInformation mapping added #537
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ns and Answers separately
jakzal
reviewed
Sep 1, 2024
| .ForMember(m => m.Telephone, o => o.MapFrom(m => m.Telephone)) | ||
| .ForMember(m => m.Url, o => o.MapFrom(m => !string.IsNullOrWhiteSpace(m.Url) ? new Uri(m.Url) : default)); | ||
|
|
||
| CreateMap<OrganisationInformation.PartyRole, OrganisationInformation.PartyRole>(); |
There was a problem hiding this comment.
@jakzal and @maciej-goaco
I can see lots of mapping done for Supplier Information , the supplier information holds the following data as well but I cannot see that is mapped. I am not sure should this be mapped as well? There is no description in the PR :)
public List Qualifications { get; set; } = [];
public List TradeAssurances { get; set; } = [];
public LegalForm? LegalForm { get; set; }
There was a problem hiding this comment.
This will be part of the detail of supplier information. Good spot 👍
jakzal
reviewed
Sep 1, 2024
Services/CO.CDP.OrganisationInformation.Persistence/OrganisationInformationContext.cs
Outdated
Show resolved
Hide resolved
We miss the name, but questions identifier is closer to its original intent than the question title.
jakzal
reviewed
Sep 1, 2024
Services/CO.CDP.DataSharing.WebApi/AutoMapper/DataSharingProfile.cs
Outdated
Show resolved
Hide resolved
glgoaco
approved these changes
Sep 2, 2024
… and correct type" This reverts commit 9b26ce1.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.