Remove requires in *-platform modules #900
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HGuillemet
changed the title
|
I'm not sure if it's normal than the requires towards the macos module is commented out in the cuda presets. |
Yes, CUDA no longer supports Mac, but some users may want to backport some stuff to older versions, you never know... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows an app to have a
*-platformmodule in its module graph without bringing into the graph all existing implementations of the native library.Meant to work with the use of
javacpp.plaformproperty and the new additions to javafx-maven-plugin.See Add option to populate module path with all maven dependencies #91