Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support building OpenCV headless #667

Merged
merged 2 commits into from
Jan 14, 2019

Conversation

harukizaemon
Copy link
Contributor

Addresses #593: If the environment variable HEADLESS=yes then we will build OpenCV without QT, GTK, and WIN32UI.

If the environment variable HEADLESS=yes then we will build OpenCV without QT, GTK, and WIN32UI.
@saudet
Copy link
Member

saudet commented Jan 10, 2019

Looks good, but unfortunately breaks the normal builds:

../cppbuild.sh: line 56: HEADLESS: unbound variable

https://travis-ci.org/bytedeco/javacpp-presets/jobs/477373066

Assigns default value of `no`. There are other ways to handle this but I liked that this makes the default behaviour pretty clear.
@harukizaemon
Copy link
Contributor Author

harukizaemon commented Jan 10, 2019

Looks good, but unfortunately breaks the normal builds:

That's totally my bad. I only ran the OpenCV build so I didn't see the set -eu.

I have pushed another change that assigns a default value of no. I'm sure there are other ways to handle this but I liked that this makes the default behaviour pretty clear.

@harukizaemon
Copy link
Contributor Author

I noticed the AppVeyor build was cancelled. The Travis CI build now passes. Is there something else I need to do?

@saudet
Copy link
Member

saudet commented Jan 11, 2019

No, looks fine! Thanks

@saudet saudet merged commit 4e2ab86 into bytedeco:master Jan 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants