OpenCV: Added support for nD to AbstractMat #647
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HGuillemet
changed the title
saudet
reviewed
Nov 29, 2018
| int size = arraySize(); | ||
| int dims = dims(); | ||
| int depth = depth(); | ||
| int elemSize = CV_ELEM_SIZE1(depth); |
There was a problem hiding this comment.
I think we could just call elemSize1() here instead?
There was a problem hiding this comment.
Ok, I didn't spot this method. It'll trigger a JNI call but I guess we don't care here.
CV_ELEM_SIZE1 definition can be deleted then.
|
BTW, |
|
I think it may theoretically still happen. But in practice that would be a very weird data layout. I'd keep the check and the exception thrown. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AbstractArray.createIndexer doesn't support Mat with more than 2 dimensions.
Added AbstractMat.createIndexer that does.
The channels are considered as an additional dimension in the indexer, but this dimension
can be omitted in a long[] array of indices for mats with only 1 channel.
One limitation : Mat theoretically accepts steps that are not multiple of the element size, but indexer does not. An exception is thrown by createIndexer if this occurs.
In JavaCPP, Indexer.rows, cols, width, heads, channels should also be deprecated or modified to return -1 if the number of dimensions of the indexer is not 3.