Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct linking of FlyCapture2 on Windows to work with v.2.12.3.2 #613

Merged
merged 8 commits into from
Dec 21, 2018

Conversation

jpsacha
Copy link
Member

@jpsacha jpsacha commented Sep 1, 2018

No description provided.

@saudet
Copy link
Member

saudet commented Sep 1, 2018

Thanks! Could you also update the archives for CI?

@jpsacha
Copy link
Member Author

jpsacha commented Oct 31, 2018

@saudet I do not have all those binary setups to pull binaries, especially x86 linux and arm.

@vb216 Do you have binaries for FlyCapture_2.12.3.2 for all those systems.

@vb216
Copy link
Member

vb216 commented Nov 17, 2018

I don't have them.. went to their download website https://www.ptgrey.com/support/downloads and picked a camera at random, I can only see 2.13.3.31 downloads now, even trying a few different cameras. So looks like they've released a newer version in the meantime, and I can't see any historical downloads section

@saudet
Copy link
Member

saudet commented Nov 17, 2018

@vb216 Ok that's fine, let's go with 2.13 and @jpsacha will update this PR for that version. :)

The main change in 2.13.3.31 is addition of new video library: new headers, and new libs.

Binaries for CI tests still need to be updated.
@jpsacha
Copy link
Member Author

jpsacha commented Dec 12, 2018

@saudet I updated for latest released version 2.13. @vb216 please add the CI test binaries.

@vb216
Copy link
Member

vb216 commented Dec 12, 2018

Was planning on adding a function into the ci script for it to unpack the unmodified SDKs.. not sure best way to get that into this pull request? Open to suggestions.. only can come up with average solutions so far. Meantime will get the code working

@saudet
Copy link
Member

saudet commented Dec 12, 2018 via email

@jpsacha
Copy link
Member Author

jpsacha commented Dec 13, 2018

@vb216 I added you as a collaborator to my fork [https://github.com/jpsacha/javacpp-presets]. Hopefully this will help to update the PR.

@vb216
Copy link
Member

vb216 commented Dec 15, 2018

So I tested over here, https://travis-ci.org/vb216/javacpp-presets/builds/468367814, and it built OK, I've then just pushed that set of changes to the install-travis.sh.. looks like they're picked up on this pull request but some merge conflict - I think thats just an older flycap source file though?
Should be easier in future now, the logic is added in to unpack any unmodified SDK file and put the files in required place to build.

@saudet
Copy link
Member

saudet commented Dec 15, 2018 via email

@saudet
Copy link
Member

saudet commented Dec 20, 2018

Actually, this one looks good to merge. I'll let the build run, and we'll merge this when it's done.

@saudet
Copy link
Member

saudet commented Dec 20, 2018

Nope, the build is failing on Windows:

[ERROR] Failed to execute goal org.bytedeco:javacpp:1.4.4-SNAPSHOT:build (javacpp.parser) on project flycapture: Failed to execute JavaCPP Builder: Could not parse "FlyCapture2VideoDefs.h": File does not exist -> [Help 1]

https://ci.appveyor.com/project/Bytedeco/javacpp-presets/builds/21138224/job/gthj2pqu11j9957q

We'll need to fix this before we can merge.

@saudet saudet merged commit 8d6391d into bytedeco:master Dec 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants