Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add OutputVector class and a more complex example to Tensorflow #563

Merged
merged 2 commits into from
May 26, 2018
Merged

Add OutputVector class and a more complex example to Tensorflow #563

merged 2 commits into from
May 26, 2018

Conversation

Neiko2002
Copy link
Member

I have created a smaller version of the ExampleTrainer script and was working on a complete training example. In order to finish it some additional features were needed. e.g. the AddN constructor needed an InputList which itself requires a vector of outputs. The vector does not exists right now, as far as I know.

public AddN(@Const @ByRef Scope scope, @ByVal InputList inputs) 
...
public InputList(@StdVector Output out)

The sames goes for the AddSymbolicGradients method

public static native @ByVal Status AddSymbolicGradients(@Const @ByRef Scope scope,
                            @StdVector Output outputs,
                            @StdVector Output inputs,
                            @StdVector Output grad_outputs)

This PR creates a OutputVector class and adds three examples: a simpler version of the ExampleTrainer script, a InputListExample and the more sophisticated examples requested in issue #409.

@saudet
Copy link
Member

saudet commented May 22, 2018

Looks good, thanks! Since the samples are not run as tests though, could we put them under the samples subdirectory in their own little project with a pom.xml file to make them more accessible? (FYI, I'd eventually like to run samples automatically as part of tests, but don't worry about that for now.)

@Neiko2002
Copy link
Member Author

There is now a sub directory in tensorflow called "samples" containing its own maven project. All code samples are there.

@saudet saudet merged commit 07362ae into bytedeco:master May 26, 2018
@Neiko2002 Neiko2002 deleted the PR branch May 29, 2018 22:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants