Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Intel QSV with ffmpeg #485

Merged
merged 6 commits into from
Dec 5, 2017
Merged

Intel QSV with ffmpeg #485

merged 6 commits into from
Dec 5, 2017

Conversation

n-kai-cj
Copy link
Contributor

I'd like to build libmfx into ffmpeg on windows platform.
libmfx enables Intel QSV codec and I've checked this pull request without any errors on windows-x86_64.
Can you merge it?

@saudet
Copy link
Member

saudet commented Nov 24, 2017

Thanks! Would it be possible to add it to the other platforms as well?

@n-kai-cj
Copy link
Contributor Author

Yes, linux can be.
But sorry, I don't have any platforms except windows so I can't test it.

@saudet
Copy link
Member

saudet commented Nov 24, 2017

That's alright, Travis CI will test it :) Thanks

@saudet
Copy link
Member

saudet commented Nov 25, 2017

So it builds fine on Windows, please update for the other platforms! Thanks

@saudet
Copy link
Member

saudet commented Nov 29, 2017

Could you try to add the following lines for the other platforms as well and see what happens?

        cd ../mfx_dispatch-$MFX_VERSION
        autoreconf -fiv
        PKG_CONFIG_PATH="../lib/pkgconfig" ./configure --prefix="`pwd`/.." --disable-shared --enable-static --enable-fast-install
        make
        make install

@n-kai-cj
Copy link
Contributor Author

I only have windows-x86_64 platform, so I can't try on other platforms.
But it seems libmfx cannot be built into ffmpeg on linux because official ffmpeg on linux doesn't contain libmfx.
Android and macos don't apply libmfx as well.
So I removed --enable-libmfx from ENABLE args and committed.

The only modification on windows can't be merged?

@saudet
Copy link
Member

saudet commented Nov 29, 2017

We can build libmfx on other platforms as easily as on Windows. Just add the same kind of build commands as you did for Windows, and then we can check if there are any builds issues here:
https://travis-ci.org/bytedeco/javacpp-presets/pull_requests
You don't need to install anything to try the build on other platforms because Travis CI does it for you. Please give it a try!

@n-kai-cj
Copy link
Contributor Author

n-kai-cj commented Nov 29, 2017

Really? That's a good news.
So I have to add your lines for android-x86, linux-x86, linux-x86_64, macosx-x86_64, windows-x86, and windows-x86_64 right? Or add for all platforms?

Anyway, I'll test for all platforms and look forward to the result of Travis CI.

@saudet
Copy link
Member

saudet commented Nov 30, 2017

Yes, like that, thanks! It looks like we'll need to resolve the conflict before Travis CI runs your pull request though.

@saudet
Copy link
Member

saudet commented Dec 1, 2017

Unfortunately, it fails on all platforms except Windows :(
https://travis-ci.org/bytedeco/javacpp-presets/builds/309838539
https://ci.appveyor.com/project/Bytedeco/javacpp-presets/build/289
If you could take a look at the error messages and try to fix this, it would be great!

@n-kai-cj
Copy link
Contributor Author

n-kai-cj commented Dec 2, 2017

I knew it...
As I said libmfx is built into official ffmpeg for only windows.
It seems linux needs to install Intel Media Server Studio, and Intel QSV uses Core iX CPU, so arm or ppc processor cannot use Intel QSV.

Anyway, I think it cannot be helped.
The only modification on windows can't be merged?

@saudet
Copy link
Member

saudet commented Dec 3, 2017 via email

@saudet
Copy link
Member

saudet commented Dec 3, 2017

But it looks like it wouldn't do anything on other platforms than linux-x86 and linux-x86_64. So let's get it working on at least those 2?

@saudet saudet merged commit a1b689a into bytedeco:master Dec 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants