Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accelerate BLAS #444

Closed
wants to merge 12 commits into from
Closed

Accelerate BLAS #444

wants to merge 12 commits into from

Conversation

ibinti
Copy link

@ibinti ibinti commented Jul 16, 2017

Address the issue #436

Copy link
Member

@saudet saudet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, but there are a lot of unrelated files. Please start by cleaning this up a bit.

@ibinti
Copy link
Author

ibinti commented Jul 17, 2017

Could you give me a hint how I can clean unrelated files? Sorry, I am not much familiar with PR yet.

@saudet
Copy link
Member

saudet commented Jul 17, 2017 via email

@saudet
Copy link
Member

saudet commented Jul 18, 2017

I see you're only mapping BLAS and LAPACK. Could you make this work with the presets for OpenBLAS instead?

@saudet saudet force-pushed the master branch 3 times, most recently from a1fa858 to 22f9ebd Compare September 24, 2017 11:23
@saudet
Copy link
Member

saudet commented Jan 17, 2018

BTW, I have a better idea on how to go about this. We should create a new generic presets for "netlib", which would be able to bind not only to Accelerate, OpenBLAS, or MKL but to others like AMD BLAS as well, in a fashion similar to the now defunct https://github.com/fommil/netlib-java project. Would you like to work on that?

@saudet
Copy link
Member

saudet commented Feb 2, 2018

I've made the necessary modifications in the commit above to be able to use Accelerate, etc with the bindings for OpenBLAS, so no need of separate presets for netlib for now. Instructions for Mac OS X at
https://github.com/bytedeco/javacpp-presets/tree/master/openblas#documentation

And thanks to @johanvos, when pull #515 gets merged, we should be able to do the same with iOS!

@saudet saudet closed this Feb 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants