Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added OpenCV contirbution Bioinspired package #281

Closed
wants to merge 4 commits into from
Closed

Added OpenCV contirbution Bioinspired package #281

wants to merge 4 commits into from

Conversation

Maurice-Betzel
Copy link
Contributor

Added OpenCV contribution Bioinspired package, including a patch for CMake 3.5 crashing in cl2cpp.cmake #6370 . Tested on Windows x86_64 and RHEL x_86_64.
The patch was not needed for the Linux build.

@saudet
Copy link
Member

saudet commented Sep 10, 2016

We're not building with OpenCL, so we shouldn't need to patch anything there... ?

In any case, please squash your commits into one! The easiest way is to git reset your fork to the last commit that isn't yours, and git commit again all your changes, and finally git push --force. Thanks a lot for the contribution!

@Maurice-Betzel
Copy link
Contributor Author

Hello Samuel, if i do not patch the compile process finishes with reporting failure for bioinspired.
Concerning git, will do.

@Maurice-Betzel
Copy link
Contributor Author

It on #282 now

@saudet
Copy link
Member

saudet commented Sep 10, 2016

We don't need to create a new pull request to update it. Please refrain from duplicating pull requests like that!

@Maurice-Betzel
Copy link
Contributor Author

Thanks for your correction. I have put 'read a good book about git' on my agenda.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants