Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CPython] Add platform macosx-arm64 #1511

Merged
merged 8 commits into from
Jun 28, 2024

Conversation

HGuillemet
Copy link
Collaborator

Add support of apple silicon mac to cpython presets.

There are constants in global/python.java that map platform-specific configurations like HAVE_*. They'd better be skipped.

@saudet
Copy link
Member

saudet commented Jun 26, 2024

Please do the same with numpy and scipy

@HGuillemet
Copy link
Collaborator Author

Please do the same with numpy and scipy

I'm waiting for the merge of this one since numpy depends on cpython

@saudet saudet merged commit 7bd5667 into bytedeco:master Jun 28, 2024
5 checks passed
@HGuillemet HGuillemet deleted the cpython-macosx-arm64 branch June 28, 2024 12:00
@saudet
Copy link
Member

saudet commented Jun 30, 2024

This breaks the build for at least OpenCV:
https://github.com/bytedeco/javacpp-presets/actions/runs/9632851195/job/26858888577
Could you fix that before trying to get SciPy working?

@HGuillemet
Copy link
Collaborator Author

This breaks the build for at least OpenCV: https://github.com/bytedeco/javacpp-presets/actions/runs/9632851195/job/26858888577 Could you fix that before trying to get SciPy working?

The macosx-arm64 builds should now use the macos-14 runner, which is an arm64 machine.

@HGuillemet
Copy link
Collaborator Author

Do you want a separate PR for this change in opencv workflow ?

@saudet
Copy link
Member

saudet commented Jun 30, 2024

Yes, please!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants