Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

virtual #1475

Merged
merged 3 commits into from
Mar 3, 2024
Merged

virtual #1475

merged 3 commits into from
Mar 3, 2024

Conversation

alfabouh
Copy link
Contributor

Virtual methods fix

@saudet saudet requested a review from mode89 February 22, 2024 08:12
mode89
mode89 approved these changes Feb 23, 2024
View reviewed changes
Copy link
Member

@mode89 mode89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@alfabouh
Copy link
Contributor Author

Is everything okay? Will these changes be added to the main branch?

@saudet saudet merged commit 351d203 into bytedeco:master Mar 3, 2024
6 checks passed
@alfabouh
Copy link
Contributor Author

alfabouh commented Mar 3, 2024

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saudet saudet saudet approved these changes

@mode89 mode89 mode89 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@alfabouh @saudet @mode89